From: Jeff King <peff@peff.net>
Date: Thu, 29 Mar 2018 17:50:42 GMT
Subject: Re: [PATCH 3/4] set_work_tree: use chdir_notify
Message-ID: <20180329175042.GD31833@sigill.intra.peff.net>
In-Reply-To: <CACsJy8DP_D14ZwJnNjkqPDBXCyXYkW9mK_boqZDRxiTUFhMmMA@mail.gmail.com>

On Thu, Mar 29, 2018 at 07:23:17PM +0200, Duy Nguyen wrote:

> On Thu, Mar 29, 2018 at 7:02 PM, Duy Nguyen <pclouds@gmail.com> wrote:
> > ...
> >
> > It's less code this way, but it uses up more of your (or my) time
> > because even though the first set_git_dir() call actually happens at 8
> > places. Is it worth trying ?
> 
> Never mind. I took a stab anyway. The setup code should have much less
> side effect before we can do stuff like this.

Oh, I should have read this before responding. Oh well. :)

-Peff