From: Jonathan Tan <jonathantanmy@google.com>
Date: Tue, 27 Mar 2018 23:07:16 GMT
Subject: Re: [PATCH 4/5] submodule-config: remove submodule_from_cache
Message-ID: <20180327160716.eec5ae96c7c1c5135b27b08e@google.com>
In-Reply-To: <20180327213918.77851-5-sbeller@google.com>

On Tue, 27 Mar 2018 14:39:17 -0700
Stefan Beller <sbeller@google.com> wrote:

> This continues the story of bf12fcdf5e (submodule-config: store
> the_submodule_cache in the_repository, 2017-06-22).
> 
> The previous patch taught submodule_from_path to take a repository into
> account, such that submodule_from_{path, cache} are the same now.
> Remove submodule_from_cache, migrating all its callers to
> submodule_from_path.
> 
> Signed-off-by: Stefan Beller <sbeller@google.com>

Obviously correct, since submodule_from_{path,cache} are word-for-word
identical (other than parameter names).

Reviewed-by: Jonathan Tan <jonathantanmy@google.com>