From: Jonathan Tan Date: Mon, 19 Mar 2018 20:10:57 GMT Subject: Re: [PATCH 39/44] packfile: allow prepare_packed_git_one to handle arbitrary repositories Message-ID: <20180319131057.7cf5c90d55b34542f691cee8@google.com> In-Reply-To: <20180303113637.26518-40-pclouds@gmail.com> On Sat, 3 Mar 2018 18:36:32 +0700 Nguyễn Thái Ngọc Duy wrote: > From: Stefan Beller > > Signed-off-by: Stefan Beller > Signed-off-by: Junio C Hamano > Signed-off-by: Nguyễn Thái Ngọc Duy Thanks - I've checked that none of the functions invoked in prepare_packed_git_one() access the_repository. (add_packed_git() does not, despite its name.) The patches up to this one are fine. [snip] > - for (p = the_repository->objects.packed_git; p; > + for (p = r->objects.packed_git; p; Optional: this could be get_packed_git(r).