From: Jeff King Date: Tue, 27 Feb 2018 21:47:13 GMT Subject: Re: [PATCH 0/5] roll back locks in various code paths Message-ID: <20180227214712.GD6899@sigill.intra.peff.net> In-Reply-To: On Tue, Feb 27, 2018 at 10:30:08PM +0100, Martin Ă…gren wrote: > Patches 2-4 are the actual fixes where I teach some functions to always > roll back the lock they're holding. Notably, these are all in "libgit". > > Patch 1 is a "while at it" to use locks on the stack instead of having > them be static. Patch 5 removes code to roll back locks which are > already rolled back. These all look good to me. Happy to see us dropping the "static" from more lockfiles, too. -Peff