From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 27 Feb 2018 06:21:28 GMT
Subject: Re: [PATCH v3 14/35] connect: request remote refs using v2
Message-ID: <20180227062128.GG65699@aiede.svl.corp.google.com>
In-Reply-To: <20180222112533.0d7c6023fb8e4098efedfe31@google.com>

Jonathan Tan wrote:
> On Thu, 22 Feb 2018 13:26:58 -0500
> Jeff King <peff@peff.net> wrote:

>> I agree that it shouldn't matter much here. But if the name argv_array
>> is standing in the way of using it, I think we should consider giving it
>> a more general name. I picked that not to evoke "this must be arguments"
>> but "this is terminated by a single NULL".
[...]
> This sounds reasonable - I withdraw my comment about using struct
> string_list.

Marking with #leftoverbits as a reminder to think about what such a
more general name would be (or what kind of docs to put in
argv-array.h) and make it so the next time I do a search for that
keyword.

Thanks,
Jonathan