From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Sun, 25 Feb 2018 20:34:01 GMT
Subject: Re: [PATCH v3 0/6] Fix initializing the_hash_algo
Message-ID: <20180225203401.GF4620@genre.crustytoothpaste.net>
In-Reply-To: <20180225111840.16421-1-pclouds@gmail.com>

On Sun, Feb 25, 2018 at 06:18:34PM +0700, Nguyễn Thái Ngọc Duy wrote:
> v3 refines v2 a bit more:
> 
> - fix configure typo (and stray words in commit message)
> - use repo_set_hash_algo() instead of reassigning the_hash_algo
> - compare hash algos by format_id
> - catch NULL hash algo, report nicely and suggest GIT_HASH_FIXUP
> 
> The last point makes me much happier about keeping this workaround
> around until we are confident we can live without it. Interdiff

This looks sane to me.

Reviewed-by: brian m. carlson <sandals@crustytoothpaste.net>
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204