From: brian m. carlson Date: Fri, 23 Feb 2018 22:17:46 GMT Subject: Re: [PATCH 1/2] setup.c: initialize the_repository correctly in all cases Message-ID: <20180223221746.GJ6619@genre.crustytoothpaste.net> In-Reply-To: <20180223095640.25876-2-pclouds@gmail.com> On Fri, Feb 23, 2018 at 04:56:39PM +0700, Nguyễn Thái Ngọc Duy wrote: > [3] the reason server side is still running ok with no hash algo > before [2] is because the programs that use enter_repo() do very > little then spawn a new program (like pack-objects or > upload-archive) to do the heavy lifting. These programs already > use setup_git_dir..() You have "..()" here. Did you want to say "()." instead? -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204