From: Brandon Williams <bmwill@google.com>
Date: Thu, 22 Feb 2018 18:56:52 GMT
Subject: Re: [PATCH v3 30/35] remote-curl: create copy of the service name
Message-ID: <20180222185652.GI185096@google.com>
In-Reply-To: <20180221160606.af3db12daeed08ba68bd37f8@google.com>

On 02/21, Jonathan Tan wrote:
> On Tue,  6 Feb 2018 17:13:07 -0800
> Brandon Williams <bmwill@google.com> wrote:
> 
> > Make a copy of the service name being requested instead of relying on
> > the buffer pointed to by the passed in 'const char *' to remain
> > unchanged.
> > 
> > Signed-off-by: Brandon Williams <bmwill@google.com>
> 
> Probably worth mentioning in the commit message:
> 
>   Currently, all service names are string constants, but a subsequent
>   patch will introduce service names from external sources.
> 
> Other than that,
> 
> Reviewed-by: Jonathan Tan <jonathantanmy@google.com>

I'll add that.

-- 
Brandon Williams