From: Jonathan Tan Date: Thu, 22 Feb 2018 00:09:05 GMT Subject: Re: [PATCH v3 32/35] http: allow providing extra headers for http requests Message-ID: <20180221160905.5772106219ded5f16919de46@google.com> In-Reply-To: <20180207011312.189834-33-bmwill@google.com> On Tue, 6 Feb 2018 17:13:09 -0800 Brandon Williams wrote: > @@ -172,6 +172,8 @@ struct http_get_options { > * for details. > */ > struct strbuf *base_url; > + > + struct string_list *extra_headers; Document this? For example: If not NULL, additional HTTP headers to be sent with the request. The strings in the list must not be freed until after the request.