From: Jonathan Tan <jonathantanmy@google.com>
Date: Wed, 21 Feb 2018 23:51:43 GMT
Subject: Re: [PATCH v3 24/35] connect: refactor git_connect to only get the protocol version once
Message-ID: <20180221155143.02c9a1c15e54f13ae99464d4@google.com>
In-Reply-To: <20180207011312.189834-25-bmwill@google.com>

On Tue,  6 Feb 2018 17:13:01 -0800
Brandon Williams <bmwill@google.com> wrote:

> Instead of having each builtin transport asking for which protocol
> version the user has configured in 'protocol.version' by calling
> `get_protocol_version_config()` multiple times, factor this logic out
> so there is just a single call at the beginning of `git_connect()`.
> 
> This will be helpful in the next patch where we can have centralized
> logic which determines if we need to request a different protocol
> version than what the user has configured.
> 
> Signed-off-by: Brandon Williams <bmwill@google.com>

Reviewed-by: Jonathan Tan <jonathantanmy@google.com>