From: Jonathan Tan Date: Wed, 21 Feb 2018 22:56:39 GMT Subject: Re: [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns Message-ID: <20180221145639.c6cf2409ce2120109bdd169f@google.com> In-Reply-To: <20180207011312.189834-16-bmwill@google.com> On Tue, 6 Feb 2018 17:12:52 -0800 Brandon Williams wrote: > @@ -21,7 +22,8 @@ struct transport_vtable { > * the ref without a huge amount of effort, it should store it > * in the ref's old_sha1 field; otherwise it should be all 0. > **/ > - struct ref *(*get_refs_list)(struct transport *transport, int for_push); > + struct ref *(*get_refs_list)(struct transport *transport, int for_push, > + const struct argv_array *ref_patterns); Also mention in the documentation that this function is allowed to return refs that do not match the ref patterns.