From: Jeff King <peff@peff.net>
Date: Fri, 16 Feb 2018 18:35:23 GMT
Subject: Re: [PATCH] test-lib.sh: unset XDG_CACHE_HOME
Message-ID: <20180216183523.GA22021@sigill.intra.peff.net>
In-Reply-To: <6f102a37a06940f6feeeb0c8807ac98a850b7a3b.1518748907.git.sky@genki.is>

On Thu, Feb 15, 2018 at 09:46:04PM -0500, Genki Sky wrote:

> git respects XDG_CACHE_HOME for the credential cache. So, we should
> unset XDG_CACHE_HOME for the test environment, lest a user's custom one
> cause failure in the test.
> 
> For example, t/t0301-credential-cache.sh expects a default directory
> to be used if it hasn't explicitly set XDG_CACHE_HOME.

Yep, this makes perfect sense. I can't believe it took almost a year for
somebody to trigger this. I guess most people don't set XDG_CACHE_HOME.

Thanks.

-Peff