From: Jeff King Date: Thu, 15 Feb 2018 05:53:34 GMT Subject: Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent Message-ID: <20180215055334.GN18780@sigill.intra.peff.net> In-Reply-To: <01020161890f4376-0d1c5615-ae9c-4320-bc2d-fd3bda19bce0-000000@eu-west-1.amazonses.com> On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote: > Remove connection between expand_data variable > in cat-file and in ref-filter. > It will help further to get rid of using expand_data in cat-file. I have to admit I'm confused at this point about what is_cat_file is for, or even why we need cat_file_data. Shouldn't these items be handled by their matching ref-filter atoms at this point? -Peff