From: Jeff King Date: Thu, 15 Feb 2018 05:42:03 GMT Subject: Re: [PATCH v3 12/23] cat-file: start reusing populate_value() Message-ID: <20180215054203.GJ18780@sigill.intra.peff.net> In-Reply-To: <01020161890f435c-c3044984-d9aa-4aaf-90e3-1affa109b3b3-000000@eu-west-1.amazonses.com> On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote: > Move logic related to getting object info from cat-file to ref-filter. > It will help to reuse whole formatting logic from ref-filter further. This feels like another wrong-direction step, because we'd eventually expect populate_value() to be called under the hood. And I think in the end we end up back there. Which is good, but it's hard to keep track of the dead-ends here... -Peff