From: Jeff King <peff@peff.net>
Date: Thu, 15 Feb 2018 05:40:18 GMT
Subject: Re: [PATCH v3 09/23] cat-file: start use ref_array_item struct
Message-ID: <20180215054018.GI18780@sigill.intra.peff.net>
In-Reply-To: <01020161890f435d-05435bc4-30da-41c4-8bb2-37dcccb4a413-000000@eu-west-1.amazonses.com>

On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:

> Moving from using expand_data to ref_array_item structure.
> That helps us to reuse functions from ref-filter easier.

This one feels weird. The point of a ref_array_item is for the caller to
feed data into the ref-filter formatting code (usually that data comes
from an earlier call to filter_refs(), but in the new cat-file we'd
presumably feed single items).

But here we're adding a bunch of fields for items that we'd expect the
format code to compute itself.

-Peff