From: Jonathan Nieder Date: Wed, 14 Feb 2018 22:43:34 GMT Subject: Re: [PATCH 2/8] perl: move CPAN loader wrappers to another namespace Message-ID: <20180214224334.GB136185@aiede.svl.corp.google.com> In-Reply-To: <20180214222146.10655-3-avarab@gmail.com> Ævar Arnfjörð Bjarmason wrote: > Move the Git::Error and Git::Mail::Address wrappers to the > Git::LoadCPAN::Loader::* namespace, e.g. Git::LoadCPAN::Error, that > module will then either load Error from CPAN (if installed on the OS), > or use Git::FromCPAN::Error. [...] > This also makes things a bit less confusing since there was already a > Git::Error namespace ever since 8b9150e3e3 ("Git.pm: Handle failed > commands' output", 2006-06-24). > > Signed-off-by: Ævar Arnfjörð Bjarmason Makes sense. Reviewed-by: Jonathan Nieder