From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Fri, 09 Feb 2018 11:04:38 GMT
Subject: Re: [PATCH v2 3/3] worktree: teach "add" to check out existing branches
Message-ID: <20180209110437.GF2130@hank>
In-Reply-To: <CACsJy8BEKYqW+Ne_WY2RBaSbb9OKcjREtrawStj=eJsVsia_Jw@mail.gmail.com>

On 02/06, Duy Nguyen wrote:
> On Tue, Feb 6, 2018 at 3:23 AM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
> > On 02/05, Duy Nguyen wrote:
> >> On Sun, Feb 04, 2018 at 10:13:05PM +0000, Thomas Gummerer wrote:
> >> > -   if (opts->new_branch)
> >> > +   if (opts->checkout_existing_branch)
> >> > +           fprintf(stderr, _(", checking out existing branch '%s'"),
> >> > +                   refname);
> >> > +   else if (opts->new_branch)
> >> >             fprintf(stderr, _(", creating new branch '%s'"), opts->new_branch);
> >>
> >> I wonder if "creating branch" and "checkout out branch" are enough.
> >
> > I thought printing the branch name might be a good idea just to show
> > more clearly what the dwim did.
> 
> No no printing branch name is definitely a good idea, especially when
> I think of one thing and type another. I shortened my example phrases
> too much. It should have been "creating branch %s" and "checkout out
> branch %s"

Ah sorry I misunderstood.  Yeah I think that makes sense then :)

> -- 
> Duy