From: Duy Nguyen Date: Mon, 22 Jan 2018 12:14:26 GMT Subject: Re: [PATCH v2 00/14] Some fixes and bunch of object_id conversions Message-ID: <20180122121426.GD5980@ash> In-Reply-To: On Mon, Jan 22, 2018 at 12:04:23PM +0100, Patryk Obara wrote: > sha1_file.c | 100 ++++++++++++++------------ You have started the invasion to sha1_file.c. Victory is near! (*) 2018 will be the year of something-other-shan-sha1 :) I've read through the series quickly. It looks good. Patches 1 and 2 should be sent separately though. (*) Technically the hashing part is still easy. I look forward to seeing you deal with the object reading part, especially from pack files. It's fun ;-) -- Duy