From: Duy Nguyen Date: Mon, 22 Jan 2018 12:03:15 GMT Subject: Re: [PATCH v2 10/14] notes: convert write_notes_tree to object_id Message-ID: <20180122120315.GC5980@ash> In-Reply-To: On Mon, Jan 22, 2018 at 12:04:33PM +0100, Patryk Obara wrote: > @@ -1141,12 +1142,13 @@ int write_notes_tree(struct notes_tree *t, unsigned char *result) > cb_data.next_non_note = t->first_non_note; > > /* Write tree objects representing current notes tree */ > - ret = for_each_note(t, FOR_EACH_NOTE_DONT_UNPACK_SUBTREES | > - FOR_EACH_NOTE_YIELD_SUBTREES, > - write_each_note, &cb_data) || > - write_each_non_note_until(NULL, &cb_data) || > - tree_write_stack_finish_subtree(&root) || > - write_sha1_file(root.buf.buf, root.buf.len, tree_type, result); > + flags = FOR_EACH_NOTE_DONT_UNPACK_SUBTREES | > + FOR_EACH_NOTE_YIELD_SUBTREES; > + ret = for_each_note(t, flags, write_each_note, &cb_data) || > + write_each_non_note_until(NULL, &cb_data) || > + tree_write_stack_finish_subtree(&root) || > + write_sha1_file(root.buf.buf, root.buf.len, tree_type, > + result->hash); Hmm.. new indentation style. I'm not complaining though. I think it looks good. -- Duy