From: Duy Nguyen Date: Mon, 22 Jan 2018 11:49:26 GMT Subject: Re: [PATCH v2 05/14] sha1_file: convert hash_sha1_file to object_id Message-ID: <20180122114925.GA5980@ash> In-Reply-To: <757646a6b42e8a0ceb50665a1fe6f588227d9873.1516617960.git.patryk.obara@gmail.com> On Mon, Jan 22, 2018 at 12:04:28PM +0100, Patryk Obara wrote: > @@ -969,7 +969,7 @@ static int ident_to_worktree(const char *path, const char *src, size_t len, > > /* step 4: substitute */ > strbuf_addstr(buf, "Id: "); > - strbuf_add(buf, sha1_to_hex(sha1), 40); > + strbuf_add(buf, sha1_to_hex(oid.hash), GIT_SHA1_HEXSZ); oid_to_hex()? -- Duy