From: Eric Wong Date: Sat, 20 Jan 2018 01:02:28 GMT Subject: Re: [PATCH v3] mru: Replace mru.[ch] with list.h implementation Message-ID: <20180120010228.hhyvirqp44taf3cz@dcvr.yhbt.net> In-Reply-To: <1516404987-3420-1-git-send-email-gs051095@gmail.com> Gargi Sharma wrote: > --- a/list.h > +++ b/list.h > @@ -93,6 +93,13 @@ static inline void list_move(struct list_head *elem, struct list_head *head) > list_add(elem, head); > } > > +/* Move to the front of the list. */ > +static inline void list_move_to_front(struct list_head *elem, struct list_head *head) > +{ > + list_del(elem); > + list_add(elem, head); > +} > + Since we already have list_move and it does the same thing, I don't think we need a new function, here. Hackers coming from other projects (glibc/urcu/Linux kernel) might appreciate having fewer differences from what they're used to. Anyways thanks for working on this!