From: Brandon Williams <bmwill@google.com>
Date: Tue, 16 Jan 2018 18:32:15 GMT
Subject: Re: [PATCH v5 6/7] trace.c: print env vars in trace_run_command()
Message-ID: <20180116183215.GB135179@google.com>
In-Reply-To: <20180115105949.18328-7-pclouds@gmail.com>

On 01/15, Nguyễn Thái Ngọc Duy wrote:
> Occasionally submodule code could execute new commands with GIT_DIR set
> to some submodule. GIT_TRACE prints just the command line which makes it
> hard to tell that it's not really executed on this repository.
> 
> Print the env delta (compared to parent environment) in this case.
> 

Code looks clean and very readable.  Also matches the last one wins
semantics in prep_childenv.

-- 
Brandon Williams