From: Brandon Williams Date: Tue, 16 Jan 2018 18:24:32 GMT Subject: Re: [PATCH v5 3/7] trace.c: move strbuf_release() out of print_trace_line() Message-ID: <20180116182432.GA135179@google.com> In-Reply-To: <20180115105949.18328-4-pclouds@gmail.com> On 01/15, Nguyễn Thái Ngọc Duy wrote: > The function is about printing a trace line, not releasing the buffer it > receives too. Move strbuf_release() back outside. This makes it easier > to see how strbuf is managed. This makes the code much more readable. -- Brandon Williams