From: Simon Ruderich <simon@ruderich.org>
Date: Sun, 14 Jan 2018 09:37:41 GMT
Subject: Re: [PATCH/RFC] diff: add --compact-summary option to complement --stat
Message-ID: <20180114093535.GA2518@ruderich.org>
In-Reply-To: <20180113132211.13350-1-pclouds@gmail.com>

On Sat, Jan 13, 2018 at 08:22:11PM +0700, Nguyễn Thái Ngọc Duy wrote:
> [snip]
>
> For mode changes, executable bit is denoted as "(+x)" or "(-x)" when
> it's added or removed respectively. The same for when a regular file is
> replaced with a symlink "(+l)" or the other way "(-l)". This also
> applies to new files. New regulare files are "A", while new executable
> files or symlinks are "A+x" or "A+l".

I like the short summary. However I find the use of parentheses
inconsistent. Why not use them either always (also for "(A+l)")
or never? Was there a specific reason why you added them just in
one place?

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9