From: Jeff King Date: Sun, 10 Dec 2017 14:53:54 GMT Subject: Re: [PATCH Outreachy 1/2] format: create pretty.h file Message-ID: <20171210145354.GA20367@sigill.intra.peff.net> In-Reply-To: On Fri, Dec 08, 2017 at 09:40:09AM -0800, Junio C Hamano wrote: > I see you've "standardized" to drop "extern" from the declarations > in the header; I have an impression that our preference however is > to go in the other direction. Can we revisit that? I haven't see any compelling reason to include the "extern" in a declaration. And all things being equal, I'd prefer the thing that makes the source code shorter, and is one less thing for authors to remember to do. -Peff