From: Jeff King Date: Thu, 30 Nov 2017 20:30:42 GMT Subject: Re: [PATCH v4 1/2] refactor "dumb" terminal determination Message-ID: <20171130203042.GB3313@sigill.intra.peff.net> In-Reply-To: <20171129143752.60553-2-lars.schneider@autodesk.com> On Wed, Nov 29, 2017 at 03:37:51PM +0100, lars.schneider@autodesk.com wrote: > From: Lars Schneider > > Move the code to detect "dumb" terminals into a single location. This > avoids duplicating the terminal detection code yet again in a subsequent > commit. Makes sense, and probably worth doing even if we don't follow through on 2/2. The patch itself looks good to me. -Peff