From: Florian Klink <flokli@flokli.de>
Date: Tue, 28 Nov 2017 00:32:35 GMT
Subject: Re: [PATCH] git-send-email: honor $PATH
Message-ID: <20171128003235.vbu3afu5junfebg7@tp.flokli.de>
In-Reply-To: <20171119123511.pck5aqak4yyc6367@tp.flokli.de>

>Support to detect sendmail binaries in windows' PATH seems a bit more complex.
>The separator is different, and PATHEXT would need to be considered too.  I'm
>not even sure if having a sendmail binary in PATH on windows is something usual
>or if defaulting to smtp to localhost (what we currently do) is good enough (tm).
>If we want to start parsing PATH under windows too, I'd suggest to use
>File::Which instead of implementing it on our own.
>
>>I would feel a lot more worried about trying elements on the $PATH
>>first and then using the two standard places as fallback.  If the
>>order of addition matters at all, that would mean that trying
>>elements on $PATH first and then falling back to the two standard
>>places *will* change the behaviour---for the affected users, we used
>>to pick one of these two, but now we would pick something different.
>>sendmail is usually installed out of the way of $PATH for regular
>>users for a reason, so picking anything whose name happens to be
>>sendmail that is on $PATH does not sound right.
>>
>>Of course, for users who do not have sendmail at one of the two
>>standard places _and_ has one on one of the directories on $PATH,
>>the order in which we check would not make a difference, so my
>>suggestion would be to do the other way around.
>
>I could happily provide a patch that does it the other way round, too. But let's
>first decide on what to do with windows ;-)

Seems like there is not really much of motivation to try better in detecting
sendmail binaries in PATH on windows ;-)

Will send patch v3, which reverses the order as suggested by Junio shortly.

-- 
Florian