From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 22 Nov 2017 05:10:14 GMT
Subject: Re: [PATCH 1/2] Git/Packet.pm: rename packet_required_key_val_read()
Message-ID: <20171122051014.GA7625@aiede.mtv.corp.google.com>
In-Reply-To: <xmqq60a3vv63.fsf@gitster.mtv.corp.google.com>

Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>> Christian Couder wrote:

>>> +# Read a text line and check that it is in the form "key=value"
>>> +sub packet_key_val_read {
>>
>> This comment doesn't tell me how to use the function.  How do I detect
>> whether it successfully read a line?  What do the return values
>> represent?  What happens if the line it read doesn't match the key?
>
> Would this work for both of you?
>
> # Read a text packet, expecting that it is in the form "key=value" for
> # the given $key.  An EOF does not trigger any error and is reported
> # back to the caller (like packet_txt_read() does).  Die if the "key"
> # part of "key=value" does not match the given $key, or the value part
> # is empty.

Yes, thank you.

Jonathan