From: Jonathan Nieder Date: Mon, 20 Nov 2017 22:04:58 GMT Subject: Re: [PATCH 3/8] connect: split git:// setup into a separate function Message-ID: <20171120220458.sxltsyheixgkunyh@aiede.mtv.corp.google.com> In-Reply-To: <20171120215218.GB92506@google.com> Brandon Williams wrote: > On 11/20, Jonathan Nieder wrote: >> + /* These underlying connection commands die() if they >> + * cannot connect. >> + */ > > I know this is really just code motion but maybe we can fix the style of > the comment here? How about doing that as a separate commit? -- >8 -- Subject: connect: correct style of C-style comment Documentation/CodingGuidelines explains: - Multi-line comments include their delimiters on separate lines from the text. E.g. /* * A very long * multi-line comment. */ Reported-by: Brandon Williams Signed-off-by: Jonathan Nieder --- connect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git i/connect.c w/connect.c index 20ed1d9574..e544a5e1dd 100644 --- i/connect.c +++ w/connect.c @@ -889,7 +889,8 @@ static struct child_process *git_connect_git(int fd[2], char *hostandport, transport_check_allowed("git"); - /* These underlying connection commands die() if they + /* + * These underlying connection commands die() if they * cannot connect. */ if (git_use_proxy(hostandport))