From: Kevin Daudt <me@ikke.info>
Date: Sun, 05 Nov 2017 02:56:47 GMT
Subject: Re: [PATCH 1/3] notes: move hex_to_bytes() to hex.c and export it
Message-ID: <20171105025647.GB23275@alpha.vpn.ikke.info>
In-Reply-To: <508b1b3f-6b55-eee8-110a-c17d572ec27a@web.de>

On Tue, Oct 31, 2017 at 02:46:49PM +0100, René Scharfe wrote:
> Make the function for converting pairs of hexadecimal digits to binary
> available to other call sites.
> 
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  cache.h |  7 +++++++
>  hex.c   | 12 ++++++++++++
>  notes.c | 17 -----------------
>  3 files changed, 19 insertions(+), 17 deletions(-)
> 
> diff --git a/cache.h b/cache.h
> index 6440e2bf21..f06bfbaf32 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -1317,6 +1317,13 @@ extern int set_disambiguate_hint_config(const char *var, const char *value);
>  extern int get_sha1_hex(const char *hex, unsigned char *sha1);
>  extern int get_oid_hex(const char *hex, struct object_id *sha1);
>  
> +/*
> + * Read `len` pairs of hexadecimal digits from `hex` and write the
> + * values to `binary` as `len` bytes. Return 0 on success, or -1 if

Is it correct to call the result binary? I would say that it's the value
that gets stored. To me, this value does not really have a base.

Kevin