From: Jeff King <peff@peff.net>
Date: Tue, 31 Oct 2017 17:10:59 GMT
Subject: Re: [PATCH v2] read_index_from(): Skip verification of the cache entry order to speed index loading
Message-ID: <20171031171058.vs5aau5x26ebx7kq@sigill.intra.peff.net>
In-Reply-To: <f671ea09-d4aa-64aa-8225-c1fbf2eac175@gmail.com>

On Tue, Oct 31, 2017 at 09:01:45AM -0400, Ben Peart wrote:

> > > But what we probably _do_ need is to make sure that "git fsck" would
> > > detect such an out-of-order index. So that developers and users alike
> > > can diagnose suspected problems.
> > 
> > Agree -- that seems like a better home for this logic.
> 
> That is how version 1 of this patch worked but the feedback to that patch
> was to remove it "not only during the normal operation but also in fsck."

Sorry for the mixed messages (I think they are mixed between different
people, and not mixed _just_ from me ;) ).

For what it's worth, I like your v1, but can live with either approach.

-Peff