From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 24 Oct 2017 23:04:13 GMT
Subject: Re: [PATCH 3/4] xdiff: use stronger hash function internally
Message-ID: <20171024230413.sm2pzlf4qhd2rirk@aiede.mtv.corp.google.com>
In-Reply-To: <20171024185917.20515-4-sbeller@google.com>

Stefan Beller wrote:

> --- a/xdiff/xutils.c
> +++ b/xdiff/xutils.c
> @@ -24,7 +24,8 @@
>  #include <assert.h>
>  #include "xinclude.h"
>  
> -
> +#include "cache.h"
> +#include "hashmap.h"

#includes like "git-compat-util.h" and "cache.h" can only be used as
the *first* #include.

Otherwise the feature test macros they set do not take effect, causing
lots of unpleasant platform-specific breakage.

Thanks,
Jonathan