From: Jeff King <peff@peff.net>
Date: Tue, 24 Oct 2017 19:46:34 GMT
Subject: Re: [PATCH 1/2] t1404: add a bunch of tests of D/F conflicts
Message-ID: <20171024194634.pigmvgoqtdexvjhc@sigill.intra.peff.net>
In-Reply-To: <CAPig+cRLB=dGD=+Af=yYL3M709LRpeUrtvcDLo9iBKYy2HAW-w@mail.gmail.com>

On Tue, Oct 24, 2017 at 12:19:26PM -0400, Eric Sunshine wrote:

> On Tue, Oct 24, 2017 at 11:16 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> > diff --git a/t/t1404-update-ref-errors.sh b/t/t1404-update-ref-errors.sh
> > @@ -34,6 +34,86 @@ test_update_rejected () {
> > +# Test adding and deleting D/F-conflicting references in a single
> > +# transaction.
> > +df_test() {
> > +       local prefix="$1"
> > +       shift
> > +       local pack=:
> 
> Isn't "local" a Bash-ism we want to keep out of the test scripts?

Yeah. It's supported by dash and many other shells, but we do try to
avoid it[1]. I think in this case we could just drop it (but keep
setting the "local foo" ones to empty with "foo=".

-Peff

[1] There's some more discussion in the thread at:

  https://public-inbox.org/git/20160601163747.GA10721@sigill.intra.peff.net/