From: Simon Ruderich <simon@ruderich.org>
Date: Fri, 20 Oct 2017 07:23:54 GMT
Subject: Re: [PATCH 4/5] diff: fix whitespace-skipping with --color-moved
Message-ID: <20171020072354.seqloliweseotuos@ruderich.org>
In-Reply-To: <20171019202926.irldca42wqosmxrd@sigill.intra.peff.net>

On Thu, Oct 19, 2017 at 04:29:26PM -0400, Jeff King wrote:
> [snip]
>
> --- a/t/t4015-diff-whitespace.sh
> +++ b/t/t4015-diff-whitespace.sh
> @@ -1463,6 +1463,73 @@ test_expect_success 'move detection ignoring whitespace changes' '
>  	test_cmp expected actual
>  '
>
> +test_expect_failure 'move detection ignoring whitespace at eol' '

Shouldn't this be test_expect_success? According to the commit
message "and a new "--ignore-space-at-eol" shows off the breakage
we're fixing.". I didn't actually run the code so I don't know if
the test fails or not.

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9