From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 17 Oct 2017 07:34:41 GMT
Subject: Re: [PATCH] check-ref-format: require a repository for --branch
Message-ID: <20171017073441.ovfhfnh5dsrbpxse@aiede.mtv.corp.google.com>
In-Reply-To: <xmqqinfentiw.fsf@gitster.mtv.corp.google.com>

Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:

>> And in that spirit, I think the patch you replied with aims to go in
>> the right direction, by providing the core functionality when in a
>> repository while avoiding breaking such a script outside of one
>> (though I do not understand it fully yet).
>
> Given that, is it safe for me to ignore this earlier one
>
>> For what it's worth, I don't agree with this repurposing of
>> "check-ref-format --branch" at all.
>
> as reacting to the patch without reading what it does?

On second reading, yes, I was reacting to the discussion leading up to
the patch instead of the patch.  The patch looks good.

Sorry for the noise,
Jonathan