From: Jeff King <peff@peff.net>
Date: Fri, 13 Oct 2017 14:26:46 GMT
Subject: Re: git-clone causes out of memory
Message-ID: <20171013142646.evapso5uxzvh2r2p@sigill.intra.peff.net>
In-Reply-To: <42cbcb4f-7f9d-df69-f55e-0ba42b931957@gmail.com>

On Fri, Oct 13, 2017 at 10:25:10AM -0400, Derrick Stolee wrote:

> This does appear to be the problem. The missing DIFF_OPT_HAS_CHANGES is
> causing diff_can_quit_early() to return false. Due to the corner-case of the
> bug it seems it will not be a huge performance improvement in most cases.
> Still worth fixing and I'm looking at your suggestions to try and learn this
> area better.

Yeah, I just timed some pathspec limits on linux.git, and it makes at
best a fraction of a percent improvement (but any improvement is well
within run-to-run noise). Which is not surprising.

I agree it's worth fixing, though.

-Peff