From: Jonathan Nieder Date: Thu, 12 Oct 2017 04:48:18 GMT Subject: Re: [PATCH 2/2] color: discourage use of ui.color=always Message-ID: <20171012044818.GE155740@aiede.mtv.corp.google.com> In-Reply-To: <20171012021007.7441-3-gitster@pobox.com> Junio C Hamano wrote: > Warn when we read such a configuration from a file, and nudge the > users to spell them 'auto' instead. > > Signed-off-by: Junio C Hamano > --- > Documentation/config.txt | 2 +- > color.c | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) This warning only kicks in when `always` is being silently downgraded to `auto`. It makes sense to me. Reviewed-by: Jonathan Nieder