From: Jonathan Tan Date: Tue, 10 Oct 2017 18:15:42 GMT Subject: Re: [PATCH v3 02/10] pkt-line: add packet_write function Message-ID: <20171010111542.1db0ccdf8899a9f501f4e1ca@google.com> In-Reply-To: <20171003201507.3589-3-bmwill@google.com> On Tue, 3 Oct 2017 13:14:59 -0700 Brandon Williams wrote: > +void packet_write(const int fd_out, const char *buf, size_t size) No need for "const" in "const int fd_out", I think. Same comment for the header file. > +{ > + if (packet_write_gently(fd_out, buf, size)) > + die_errno("packet write failed"); > +}