From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 06 Oct 2017 22:01:01 GMT
Subject: Re: [PATCH 2/2] tests: fix diff order arguments in test_cmp
Message-ID: <20171006220101.GZ19555@aiede.mtv.corp.google.com>
In-Reply-To: <20171006190006.19623-2-sbeller@google.com>

Stefan Beller wrote:

> Fix the argument order for test_cmp. When given the expected
> result first the diff shows the actual output with '+' and the
> expectation with '-', which is the convention for our tests.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---

Yes, this should make the output from failing tests easier to take in
at a glance.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

How did you find these?  E.g. is there a grep pattern that reviewers
can use to repeat your results?