From: Jeff King Date: Wed, 04 Oct 2017 07:45:48 GMT Subject: Re: [PATCH v2] oidmap: map with OID as key Message-ID: <20171004074547.56ks2efcr7cbldbq@sigill.intra.peff.net> In-Reply-To: On Tue, Oct 03, 2017 at 05:29:01PM -0700, Jonathan Tan wrote: > At this point I decided that I prefer the thin wrapper, but the "light > touch" (struct oidmap_entry, oidcmpfn(), oidmap_get() only) still > better than the status quo. OK. I can certainly live with that. And worst case, I suppose, is that a caller wants some underlying hashmap function and we just have to extend the oidmap API to include it. It's not like we're adding new hashmap functions willy-nilly. -Peff