From: Jonathan Tan Date: Tue, 26 Sep 2017 22:39:50 GMT Subject: Re: [PATCH 07/13] object-filter: common declarations for object filtering Message-ID: <20170926153950.a147c48ce62f73702eff7ebb@google.com> In-Reply-To: <20170922203017.53986-8-git@jeffhostetler.com> On Fri, 22 Sep 2017 20:30:11 +0000 Jeff Hostetler wrote: > Makefile | 1 + > object-filter.c | 269 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > object-filter.h | 173 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 443 insertions(+) > create mode 100644 object-filter.c > create mode 100644 object-filter.h I think these and list-objects-filter-* are multiple levels of indirection too many. Would a single file with a few implementations of filter_object_fn be sufficient?