From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 25 Sep 2017 22:11:01 GMT
Subject: Re: [PATCH 5/7] worktree: use xsize_t to access file size
Message-ID: <20170925221101.GD27425@aiede.mtv.corp.google.com>
In-Reply-To: <20170925203033.z4czmuhedm3f54b3@sigill.intra.peff.net>

Jeff King wrote:

> To read the "gitdir" file into memory, we stat the file and
> allocate a buffer. But we store the size in an "int", which
> may be truncated. We should use a size_t and xsize_t(),
> which will detect truncation.
>
> An overflow is unlikely for a "gitdir" file, but it's a good
> practice to model.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  builtin/worktree.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>