From: Martin Ågren <martin.agren@gmail.com>
Date: Fri, 22 Sep 2017 23:37:07 GMT
Subject: Re: [PATCH v8 08/12] fsmonitor: add a test tool to dump the index extension
Message-ID: <20170922233707.25414-2-martin.agren@gmail.com>
In-Reply-To: <20170922163548.11288-9-benpeart@microsoft.com>

On 22 September 2017 at 18:35, Ben Peart <benpeart@microsoft.com> wrote:
> Add a test utility (test-dump-fsmonitor) that will dump the fsmonitor
> index extension.
>
> Signed-off-by: Ben Peart <benpeart@microsoft.com>
> ---
>  Makefile                       |  1 +
>  t/helper/test-dump-fsmonitor.c | 21 +++++++++++++++++++++
>  2 files changed, 22 insertions(+)
>  create mode 100644 t/helper/test-dump-fsmonitor.c

You forget to add the new binary to .gitignore. (In patch 12/12, you
introduce test-drop-caches, which you _do_ add to .gitignore.)

Martin

diff --git a/t/helper/.gitignore b/t/helper/.gitignore
index 6f07de62d..0fe2e0440 100644
--- a/t/helper/.gitignore
+++ b/t/helper/.gitignore
@@ -6,6 +6,7 @@
 /test-delta
 /test-drop-caches
 /test-dump-cache-tree
+/test-dump-fsmonitor
 /test-dump-split-index
 /test-dump-untracked-cache
 /test-fake-ssh
-- 
2.14.1.727.g9ddaf86