From: Jeff King <peff@peff.net>
Date: Thu, 21 Sep 2017 04:52:00 GMT
Subject: Re: [PATCH] diff-lib: clear `pending` object-array in `index_differs_from()`
Message-ID: <20170921045200.bw2yezcwmlxvemwn@sigill.intra.peff.net>
In-Reply-To: <CAN0heSqVxBreaZN9x1XtX2OpeAoVZNzixr+vzyCWwe8UKtdtgQ@mail.gmail.com>

On Thu, Sep 21, 2017 at 05:56:21AM +0200, Martin Ågren wrote:

> > Looks good. A similar bug was the exact reason for adding the function
> > in 46be82312. I did a grep for 'free.*\.objects' to see if there were
> > other cases.
> 
> Ah. I grepped for "pending.objects", but didn't go more general than that.

I did at first, too. My optimism lessened when I ran the more general
grep. :)

> > As I suspect you're working your way through leak-checker results, I'm
> > OK if you want to punt on digging into more cases for now and just fix
> > ones that the tool has identified as real leaks.
> 
> I am indeed going through ASan results. Your UNLEAK helps immensely!
> (I'm collecting UNLEAKs on the side. I see now that UNLEAK is in master,
> so I should probably submit those where I believe things are
> "UNLEAK-complete".)

Thanks! That's exactly what I'd hoped might happen when I started on
UNLEAK.

-Peff