From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 19 Sep 2017 20:37:14 GMT
Subject: Re: [PATCH v1 1/1] test-lint: echo -e (or -E) is not portable
Message-ID: <20170919203714.GF75068@aiede.mtv.corp.google.com>
In-Reply-To: <20170917054318.28560-1-tboegi@web.de>

Torsten Bögershausen <tboegi@web.de> wrote:

> Some implementations of `echo` support the '-e' option to enable
> backslash interpretation of the following string.
> As an addition, they support '-E' to turn it off.

nit: please wrap the commit message to a consistent line width.

> However, none of these are portable, POSIX doesn't even mention them,
> and many implementations don't support them.
>
> A check for '-n' is already done in check-non-portable-shell.pl,
> extend it to cover '-n', '-e' or '-E-'
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
>  t/check-non-portable-shell.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

An excellent change.  Thanks for noticing and fixing this.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>