From: Jonathan Nieder Date: Mon, 18 Sep 2017 23:17:24 GMT Subject: Re: [OUTREACHY] pack: make packed_git_mru global a value instead of a pointer Message-ID: <20170918231724.GY27425@aiede.mtv.corp.google.com> In-Reply-To: <1505755303-5583-1-git-send-email-bugosip@gmail.com> Hi, phionah bugosi wrote: > Just to reecho a previous change requested before in one of the mail > threads, we currently have two global variables declared: > > struct mru packed_git_mru_storage; > struct mru *packed_git_mru = &packed_git_mru_storage; > > We normally use pointers in C to point or refer to the same location > or space in memory from multiple places. That means in situations > where we will have the pointer be assigned to in many places in our > code. But in this case, we do not have any other logic refering or > assigning to the pointer packed_git_mru. In simple words we actually > dont need a pointer in this case. > > Therefore this patch makes packed_git_mru global a value instead of > a pointer and makes use of list.h > > Signed-off-by: phionah bugosi > --- > builtin/pack-objects.c | 5 +++-- > cache.h | 7 ------- > list.h | 6 ++++++ > packfile.c | 12 ++++++------ > 4 files changed, 15 insertions(+), 15 deletions(-) *puzzled* This appears to already be in "pu", with a different author. Did you independently make the same change? Or are you asking for a progress report on that change, and just phrasing it in a confusing way? Confused, Jonathan