From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Thu, 14 Sep 2017 12:45:36 GMT
Subject: Re: [PATCH 2/4] push, fetch: error out for submodule entries not pointing to commits
Message-ID: <20170914124536.GA66700@book.hvoigt.net>
In-Reply-To: <20170912173027.GC144745@aiede.mtv.corp.google.com>

On Tue, Sep 12, 2017 at 10:30:27AM -0700, Jonathan Nieder wrote:
> From: Stefan Beller <sbeller@google.com>
> 
> The check_has_commit helper uses resolves a submodule entry to a
> commit, when validating its existence. As a side effect this means
> tolerates a submodule entry pointing to a tag, which is not a valid
> submodule entry that git commands would know how to cope with.
> 
> Tighten the check to require an actual commit, not a tag pointing to a
> commit.
> 
> Also improve the error handling when a submodule entry points to
> non-commit (e.g., a blob) to error out instead of warning and
> pretending the pointed to object doesn't exist.
> 
> Signed-off-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

Looks good to me.

Cheers Heiko