From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 13 Sep 2017 21:16:16 GMT
Subject: Re: [PATCH 4/7] convert less-trivial versions of "write_in_full() != len"
Message-ID: <20170913211616.GL27425@aiede.mtv.corp.google.com>
In-Reply-To: <20170913171628.o4euxlzk4imlf4tv@sigill.intra.peff.net>

Jeff King wrote:

> The prior commit converted many sites to check the return
> value of write_in_full() for negativity, rather than a
> mismatch with the input length. This patch covers similar
> cases, but where the return value is stored in an
> intermediate variable. These should get the same treatment,
> but they need to be reviewed more carefully since it would
> be a bug if the return value is stored in an unsigned type
> (which indeed, it is in one of the cases).
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  entry.c              | 5 +++--
>  refs/files-backend.c | 2 +-
>  streaming.c          | 2 +-
>  3 files changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>