From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 16 Aug 2017 00:22:57 GMT
Subject: Re: [PATCH] sub-process: print the cmd when a capability is unsupported
Message-ID: <20170816002257.GG13924@aiede.mtv.corp.google.com>
In-Reply-To: <20170815111725.5d009b66@twelve2.svl.corp.google.com>

Jonathan Tan wrote:
> Christian Couder <christian.couder@gmail.com> wrote:

>> In handshake_capabilities() we use warning() when a capability
>> is not supported, so the exit code of the function is 0 and no
>> further error is shown. This is a problem because the warning
>> message doesn't tell us which subprocess cmd failed.
[...]
>> Let's improve the warning() message, so that we can know which
>> subprocess cmd failed.
>>
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>
> This looks reasonable to me.
>
> I am still wondering if protocol errors should be fatal,

Yes, please.

Thanks,
Jonathan