From: Brandon Williams <bmwill@google.com>
Date: Mon, 24 Jul 2017 20:54:27 GMT
Subject: Re: [GSoC][PATCH 03/13] submodule: port set_name_rev() from shell to C
Message-ID: <20170724205427.GA92874@google.com>
In-Reply-To: <20170724203454.13947-4-pc44800@gmail.com>

On 07/25, Prathamesh Chavan wrote:
> +static int print_name_rev(int argc, const char **argv, const char *prefix)
> +{
> +	char *namerev;
> +	if (argc != 3)
> +		die("print-name-rev only accepts two arguments: <path> <sha1>");
> +
> +	namerev = get_name_rev(argv[1], argv[2]);
> +	if (namerev && namerev[0])
> +		printf(" (%s)", namerev);
> +	printf("\n");
> +

'namerev' needs to be freed at the end of this function.

> +	return 0;
> +}
> +

-- 
Brandon Williams